Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gocoro refactor #356

Merged
merged 20 commits into from
Jul 25, 2024
Merged

gocoro refactor #356

merged 20 commits into from
Jul 25, 2024

Conversation

dfarr
Copy link
Member

@dfarr dfarr commented Jul 13, 2024 •
edited
Loading

  • Migrate to gocoro coroutine library
  • Update DST and add porcupine for linearizability checking
  • Upgrade to go v1.22

@codecov Codecov
Copy link

codecov bot commented Jul 24, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 71.59137% with 698 lines in your changes missing coverage. Please review.

Project coverage is 55.89%. Comparing base (54be415) to head (3ed4fe6).
Report is 3 commits behind head on main.

Files Patch % Lines
test/dst/validator.go 62.68% 61 Missing and 39 partials ⚠️
internal/app/coroutines/createSubscription.go 0.00% 72 Missing ⚠️
internal/app/coroutines/claimTask.go 0.00% 63 Missing ⚠️
cmd/dst/run.go 0.00% 51 Missing ⚠️
internal/app/coroutines/completeTask.go 0.00% 46 Missing ⚠️
internal/app/coroutines/readSubscriptions.go 0.00% 42 Missing ⚠️
internal/app/coroutines/createPromise.go 69.04% 36 Missing and 3 partials ⚠️
internal/app/coroutines/deleteSubscription.go 0.00% 31 Missing ⚠️
internal/app/coroutines/notifiySubscriptions.go 0.00% 30 Missing ⚠️
internal/app/subsystems/api/grpc/promise.go 85.64% 22 Missing and 8 partials ⚠️
... and 30 more
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #356      +/-   ##
==========================================
- Coverage   58.12%   55.89%   -2.23%     
==========================================
  Files         113      124      +11     
  Lines        9943    10596     +653     
==========================================
+ Hits         5779     5923     +144     
- Misses       3796     4198     +402     
- Partials      368      475     +107

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dfarr dfarr marked this pull request as ready for review July 25, 2024 00:40
@dfarr dfarr merged commit a93e0eb into main Jul 25, 2024
28 of 29 checks passed
@dfarr dfarr deleted the refactor/coroutine branch July 25, 2024 00:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@dfarr